Skip to content

[MNG-8295] Dependency Manager Transitivity (now default) handles dependency management inconsistently#1785

Closed
DidierLoiseau wants to merge 1 commit intoapache:masterfrom
DidierLoiseau:fix/MNG-8295-use-TransitiveDependencyManager
Closed

[MNG-8295] Dependency Manager Transitivity (now default) handles dependency management inconsistently#1785
DidierLoiseau wants to merge 1 commit intoapache:masterfrom
DidierLoiseau:fix/MNG-8295-use-TransitiveDependencyManager

Conversation

@DidierLoiseau
Copy link
Copy Markdown
Contributor

Actually use TransitiveDependencyManager when maven.resolver.dependencyManagerTransitivity=true, instead of ClassicDependencyManager(true, …) as per #1357.

This fixes MNG-8295 and the integration tests proposed in apache/maven-integration-testing#379.

I thought that, since the change is trivial, it doesn’t cost much to create a PR for it already – even if the consensus turns out to be something else in the end.

  • Jira issue: MNG-8295
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.
    (with the changes in [MNG-7982] IT’s for transitive dependency management maven-integration-testing#379)

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

…ndency management inconsistently

Actually use TransitiveDependencyManager when maven.resolver.dependencyManagerTransitivity=true
@DidierLoiseau DidierLoiseau force-pushed the fix/MNG-8295-use-TransitiveDependencyManager branch from b7a6a72 to 1a43d65 Compare October 8, 2024 20:13
@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Oct 8, 2024

Superseded by #1788

@gnodet gnodet closed this Oct 8, 2024
@jira-importer
Copy link
Copy Markdown

Resolve #9962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants