MNG-6839 Added @deprecated to documentation#330
MNG-6839 Added @deprecated to documentation#330asutosh936 wants to merge 1 commit intoapache:masterfrom
Conversation
michael-o
left a comment
There was a problem hiding this comment.
There is zero benefit in this change.
|
I still see half glass full here. From documentation perspective there is no way to know this methods are deprecated, which will be available by this PR. As per what alternative method to use for deprecated one is still unknown to me (considering newbie contributor). We can go ahead with this PR and a related Jira should be created which provides list of alternative methods to be documented. Am ready to document those if I know what are the alternative ones to use. |
|
There is already the annoation |
|
I agree with @michael-o , when adding |
|
Resolve #8623 |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.