Skip to content

[MNG-7002] Added a test scenario for including child modules when usi…#387

Merged
MartinKanters merged 1 commit intoapache:masterfrom
infosupport:MNG-7002-include-unit-test-for-pl-including-children
Oct 23, 2020
Merged

[MNG-7002] Added a test scenario for including child modules when usi…#387
MartinKanters merged 1 commit intoapache:masterfrom
infosupport:MNG-7002-include-unit-test-for-pl-including-children

Conversation

@MartinKanters
Copy link
Contributor

@MartinKanters MartinKanters commented Oct 23, 2020

…ng the --pl switch.

This was easy to pick up since MNG-6118 extended the testcase with a multi-level hierarchy project:
https://github.com/apache/maven/pull/373/files#diff-72ccd31ee50f74b4685bab505c4fbbe21f1eea8c55aea23c75ad9b620a462c06R73-R80

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@MartinKanters MartinKanters merged commit 6034102 into apache:master Oct 23, 2020
@MartinKanters MartinKanters deleted the MNG-7002-include-unit-test-for-pl-including-children branch October 23, 2020 13:33
@jira-importer
Copy link

Resolve #8029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments