Upgrade github actions cache and use m2 cache for integration testing…#412
Merged
MartinKanters merged 1 commit intoapache:masterfrom Dec 15, 2020
Conversation
michael-o
approved these changes
Dec 5, 2020
Contributor
Author
|
It seems I have made a mistake, the location of the m2 repo is different in case of the integration tests. Let me fix this. |
michael-o
requested changes
Dec 6, 2020
| - name: Running integration tests | ||
| shell: bash | ||
| run: mvn install -e -B -V -Prun-its,embedded -DmavenDistro="$GITHUB_WORKSPACE/built-maven/apache-maven-bin.zip" -DwrapperDistroDir="$GITHUB_WORKSPACE/built-maven/" -DmavenWrapper="$GITHUB_WORKSPACE/built-maven-wrapper/maven-wrapper.jar" -f maven-integration-testing/pom.xml | ||
| run: mvn install -e -B -V -Prun-its,embedded -Dmaven.repo.local=~/.m2/repository -DmavenDistro="$GITHUB_WORKSPACE/built-maven/apache-maven-bin.zip" -DwrapperDistroDir="$GITHUB_WORKSPACE/built-maven/" -DmavenWrapper="$GITHUB_WORKSPACE/built-maven-wrapper/maven-wrapper.jar" -f maven-integration-testing/pom.xml |
Member
There was a problem hiding this comment.
Isn't this redundant then because it is the default value?
Contributor
Author
There was a problem hiding this comment.
I've tried that, but MavenITmng5937MavenWrapper breaks in that case.. We should probably fix that, but I'd rather see that as a separate issue.
MartinKanters
force-pushed
the
test-github-actions-dependency-cache
branch
from
3d5a895 to
70ec8f9
Compare
Contributor
Author
|
@michael-o The issues have been solved, please take another look when you have some time. |
mthmulders
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request will cache .m2 dependencies for the integration tests that are running on currently 12 different OS + JDK versions.
This should solve the (relatively) many dependency retrieval failures we get in GA jobs currently.
I've tested it under my own profile.