[MNG-7556] Clean up notion between user properties and system properties #810
Conversation
|
I hope that I didn't miss a spot... |
|
This is intended to be backported to 3.9.0. |
...re/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorV4.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java
Outdated
Show resolved
Hide resolved
|
@slawekjaranowski Any objections, opinions? |
| <version>4.0.0+</version> | ||
| <description>Specifies that this profile will be activated when this system property is | ||
| <description>Specifies that this profile will be activated when this property is | ||
| specified.</description> |
There was a problem hiding this comment.
We can't use project property for profile activation - right?
It can be user or system property.
Maybe it should be clear here?
There was a problem hiding this comment.
This needs to be checked...
There was a problem hiding this comment.
I checked PropertyProfileActivator. It DOES use user and then system properties. No project/model properties, but the passed ProfileActivationContext contains a getProjectProperties() method so we could make this happen.
|
What about org.apache.maven.cli.MavenCli#populateProperties ? I thought this is to stop doing that? |
Oh, this is against master, and am looking at 3.9.x.... my point was, will this stop injecting Maven user properties into Java System.properties? |
|
Also, this seems very much related to this PR #831 (the plexus context bit). As today Plexus uses java system properties for interpolation, while with that PR the plexus context is prepopulated with "config properties" (system + user) and there is no need that Plexus goes to System.properties as values are in context.... |
This will also be applied to 3.9.x. This PR does not change any behavior. This just clarifies that Maven CLI accepts user properties, system properties cannot be passed via CLI. Please must know that The promotion is a seperate issue which requires preparation with Maven Invoker first. I have discussed this with @slawekjaranowski already. |
asfgit
force-pushed
the
MNG-7556
branch
2 times, most recently
from
48ff3f4 to
0a8d246
Compare
|
Resolve #8894 |
6 participants
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY, where you replaceMNG-XXXand
SUMMARYwith the appropriate JIRA issue. Best practice is to use the JIRA issuetitle in the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.