Skip to content

[MNG-6609] expose packaging via property "project.packaging"#835

Merged
kwin merged 2 commits intomasterfrom
feature/profile-activation-by-packaging
Oct 24, 2022
Merged

[MNG-6609] expose packaging via property "project.packaging"#835
kwin merged 2 commits intomasterfrom
feature/profile-activation-by-packaging

Conversation

@kwin
Copy link
Member

@kwin kwin commented Oct 19, 2022

This can be used for packaging specific profiles with the property activator.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

IT PR in apache/maven-integration-testing#206

This can be used for packaging specific profiles with the property
activator.
@gnodet
Copy link
Contributor

gnodet commented Oct 21, 2022

@kwin That really looks like a hack to avoid defining a new activation type to me. Shouldn't we extend the model to add a packaging based activation ?

@kwin
Copy link
Member Author

kwin commented Oct 21, 2022

Agreed, it is kind of a workaround, but given that I think it is consensus to stick with POM 4.0 for Maven 4 this is the only near term solution I could come up with.

@kwin kwin merged commit 79b6dd0 into master Oct 24, 2022
@kwin kwin deleted the feature/profile-activation-by-packaging branch October 24, 2022 11:13
@jira-importer
Copy link

Resolve #8606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants