Skip to content

Jenkinsfile: pickup results from ITs#951

Closed
psiroky wants to merge 2 commits intoapache:masterfrom
psiroky:jenkins-pick-up-it-results
Closed

Jenkinsfile: pickup results from ITs#951
psiroky wants to merge 2 commits intoapache:masterfrom
psiroky:jenkins-pick-up-it-results

Conversation

@psiroky
Copy link
Copy Markdown
Contributor

@psiroky psiroky commented Jan 11, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [] Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • [] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Jenkinsfile Outdated
}
} finally {
//junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What with standard path, like **target/surefire-reports/*.xml and for failsafe?

Copy link
Copy Markdown
Contributor Author

@psiroky psiroky Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. I assumed these patterns were tested before and the junit step was accidentally left commented out.

I think we could go with **target/surefire-reports/*.xml. It will pick-up some test results from core-it-support, but that may be desirable.

There are no failsafe-reports directories right now, but to be safe we could include those as well.

@psiroky
Copy link
Copy Markdown
Contributor Author

psiroky commented Jan 11, 2023

I updated the PR to also pickup failsafe-reports. I haven't really tried locally, but according to https://www.jenkins.io/doc/pipeline/steps/junit/ separating the patterns with comma should work.

@psiroky
Copy link
Copy Markdown
Contributor Author

psiroky commented Jan 11, 2023

I noticed there is also Jenkinsfile.its which seems unused? Should it be just removed, or am I missing the usage somewhere?

@slawekjaranowski
Copy link
Copy Markdown
Member

@psiroky Thanks for PR, I will try it on branch in maven repo ... PR from fork are not build by jenkins

@slawekjaranowski slawekjaranowski self-assigned this Jan 11, 2023
@slawekjaranowski
Copy link
Copy Markdown
Member

Suppressed by #953

@psiroky psiroky deleted the jenkins-pick-up-it-results branch January 12, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants