This repository was archived by the owner on Jun 29, 2021. It is now read-only.
Apache Hive support #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
With this change we are now setting the autocommit to false only when the isTransactional condition is true, is this what we want?
Contributor
Author
There was a problem hiding this comment.
At least it's what I meant :-) We only have Hive in our portfolio currently that is a "non transactional" JDBC driver. In the case of Hive it is not allowed to call these methods.
Do you have an underlying concern with this specifically?
Contributor
There was a problem hiding this comment.
Ok got it! Thank you for clarifying, makes sense now.
Contributor
|
@kaspersorensen I've added some comments, please review. |
Contributor
|
Thank you @kaspersorensen These changes LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Apache Hive via the existing JDBC module.
To do this I had to introduce a new "isTransactional()" flag on IQueryRewriter since commit calls on Hive is not supported.
I also did some cleanup of Hadoop dependencies because I saw Hadoop version conflicts inbetween the "hadoop", "hbase" and now the "jdbc" modules. This caused the Hive connection to fail with class loading issues.