This repository was archived by the owner on Jun 29, 2021. It is now read-only.
Added fix for escaping in CsvWriter in case where quote char is not set #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
.contains() (both line 75 and 76)
Contributor
Author
There was a problem hiding this comment.
Actually .indexOf(...) is better here because it is a char and the search time of indexOf(char) is presumably a lot faster than contains(String) since it only has to evaluate a single character.
Contributor
|
Except for the weird |
kaspersorensen
deleted the
bug/csv-writer-escape-separator-when-not-quoted
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I discovered a small bug in MetaModel's CsvWriter - that it would fail to escape a separator char if there is no quote char. Please find here my patch for the problem.