This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-1571 Correct KAFKA_TAIL Seek to End Logic#1023
Closed
nickwallen wants to merge 2 commits intoapache:masterfrom
Closed
METRON-1571 Correct KAFKA_TAIL Seek to End Logic#1023nickwallen wants to merge 2 commits intoapache:masterfrom
nickwallen wants to merge 2 commits intoapache:masterfrom
Conversation
This was referenced May 22, 2018
Contributor
|
Documentation is very clear and everything worked perfectly. +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
KAFKA_TAIL now performs manual partition assignment and correctly uses the Kafka API to seek to the end of the topic.
Previously, the function messed with the 'group.id' to effectively seek to end. This is an abuse of the API. Also, a fixed group.id is required for using the KAFKA_* functions in a Kerberized cluster.
The unit tests for KAFKA_TAIL were improved.
KAKFA_GET and KAFKA_TAIL now use a more accurate mechanism for adhering to the user's requested max wait time.
Previously, the max wait was divided by the max poll timeout to estimate how many times Kafka should be polled before returning to the user. This method is not always accurate when some poll requests return values and others do not.
The MPack now defines a global property
bootstrap.serverswhich allow the KAFKA_* functions to work out-of-the-box after a Metron installation.Previously, a user had to manually define this property before using the KAKFA_* functions. If the property is not defined correctly, they would have to wait an excessive amount of time for the connection to timeout since there is no means in the REPL to interrupt a function call.
Testing
Launch the development environment.
Launch the REPL in the development environment.
Tail some messages from Kafka
Get some messages from Kafka.
Pull Request Checklist