METRON-1735: Empty print status option causes NPE

[merrimanr]

Contributor Comments

This is a regression in the feature branch introduced by #1138. The default behavior of PcapJob is that it should not print status by default and not fail when that setting is missing.

Changed Included

• Changed the default behavior of the Pcap CLI to print status by default
• Removed the print status flag from the CLI
• Fixed bug in getting print status option in PcapJob
• Added getter/setting methods to PcapJob for testing purposes
• Added test cases

Testing

Still testing in full dev.

• You should get result in the Pcap UI now
• The print status option in the CLI should be missing
• The CLI should print status every time

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[justinleet]

@merrimanr Could you bump Travis? Looks like a maven connection issue, rather than something to actually be fixed.

[merrimanr]

@justinleet it was something that needed to be fixed and should be good now.

[justinleet]

+1 by inspection. Thanks for catching this, it's a good fix.