This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-1938 Add Parser Debugger to READMEs#1304
Closed
nickwallen wants to merge 9 commits intoapache:masterfrom
Closed
METRON-1938 Add Parser Debugger to READMEs#1304nickwallen wants to merge 9 commits intoapache:masterfrom
nickwallen wants to merge 9 commits intoapache:masterfrom
Conversation
JonZeolla
reviewed
Dec 18, 2018
Member
JonZeolla
left a comment
JonZeolla
left a comment
There was a problem hiding this comment.
Some minor tweak suggestions. Since I was already in there poking around, I made a PR against your branch to make my suggested changes - feel free to merge (if you agree) and not worry about attribution when this gets into master.
JonZeolla
reviewed
Dec 18, 2018
Member
|
Aside from my last comment, I'm +1 |
Contributor
Author
|
Thanks @JonZeolla . I think everything you mentioned is addressed. If not, let me know. Thanks for your PR and all the effort in reviewing. |
Member
|
+1 thanks for pulling this together and the upstream work on the features themselves, I will definitely be putting them through their paces =) |
JonZeolla
pushed a commit
to JonZeolla/metron
that referenced
this pull request
Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation and examples for the Parser Debugger to the README.
Testing
Generate the site book and review the documentation for the Management functions.
Pull Request Checklist
Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html: