METRON-1962: Make entering JDBC details in REST config to be optional#1318
METRON-1962: Make entering JDBC details in REST config to be optional#1318anandsubbu wants to merge 3 commits intoapache:masterfrom
Conversation
| <display-name>User password attribute</display-name> | ||
| <description>LDAP attribute for the user password</description> | ||
| <value-attributes> | ||
| <type>password</type> |
There was a problem hiding this comment.
While I was here, I also set the LDAP password type appropriately.
There was a problem hiding this comment.
This isn't actually a password, it's the LDAP attribute that contains the password for a given user. It doesn't need the password type.
The default is just the value "userPassword", because that's at least often where the value is stored.
There was a problem hiding this comment.
Oh okay, got it. Sorry, I mis-interpreted it. Let me revert this change.
There was a problem hiding this comment.
To add to this, check out
The field is "userPassword", but the actual value is "admin-password". In an actual instance with hashed passwords it might be "userPassword:{SSHA}<hashed password>".
There was a problem hiding this comment.
Yup, makes sense.
|
@anandsubbu @justinleet Does this require any doc updates now that these values are not going to be required? |
@mmiklavc , I updated the README. Let me know what you think. |
|
@mmiklavc and @justinleet let me know if anything else is required for this PR. |
|
@anandsubbu - doc change looks good to me. I was most concerned there may have been something talking about requiring those fields in doc changes in this PR - https://github.com/apache/metron/pull/1246/files but it doesn't look like it. @justinleet can you confirm we didn't miss anything there? I'm +1 by inspection pending Justin's feedback. |
|
+1 by inspection, thanks @anandsubbu! |
|
@mmiklavc Just to answer your question explicitly, we should have been good. The change here should have been in the original PR, so I wouldn't expect any doc changes. There are ways to improve this further, but I think just making it not required for everyone is a good start. |
|
Thanks @mmiklavc and @justinleet ! |
…(anandsubbu) closes apache#1318
3 participants
Contributor Comments
The following parameters related to JDBC is now optional to enter in REST config:
** Testing Done **
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.