Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@tiborm
Copy link
Contributor

@tiborm tiborm commented Mar 7, 2019

Contributor Comments

The metron alert UI by default searches for everything, on login.
It also has a default refresh rate of 1 min.

This search is activated every time a user login to metron alerts UI. This is causing a heavy load on elastic search and as a result, slows down the RA indexing.

Furthermore, the 1-minute refresh rate sends another search request even before the first search results are returned.

We have to wait for the first query to finish before changing the refresh rate.

As part of this PR I fixing this issue by turning off polling by default (actually there was a previous atempt to turn it off but it had bug) and eliminating inital search request after login.

Testing

  • Clone this branch locally, spin up the Alerts UI manually by navigating to the alerts directory (metron-interface/metron-alerts) and running scripts/start-dev.sh, then navigate to localhost:4201
  • Make sure there is no search request sent automatically after login
  • Make sure polling is paused by default (there should be a 'play' icon on the top right of the page to start polling)

Please review and merge if you find it ok!
Thx

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@sardell
Copy link
Contributor

sardell commented Mar 8, 2019

+1 Tested locally with full dev. I'm actually surprised users haven't brought up this issue before. It makes sense not do an initial open search or default polling since we don't know how long that initial search or polling will take to return. Thanks for the contribution, @tiborm!

@mmiklavc
Copy link
Contributor

mmiklavc commented Mar 8, 2019

This looks reasonable to me @tiborm. +1 by inspection.

@asfgit asfgit closed this in 143901b Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants