This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-959 Trivial documentation formatting bugs#591
Closed
JonZeolla wants to merge 1 commit intoapache:masterfrom
Closed
METRON-959 Trivial documentation formatting bugs#591JonZeolla wants to merge 1 commit intoapache:masterfrom
JonZeolla wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
+1 by inspection. Good catch, and thanks for fixing it. |
Member
Author
|
Thanks. Just waiting on INFRA-14159 so I can commit it. |
Member
|
@JonZeolla Just let me know if you want me to commit in the meantime. I'd be happy to, but I'll understand if you want to use this to test whether your commit rights are restored. |
Member
Author
|
Planning to use this as a test commit once the permissions are fixed, unless that doesn't happen until after 0.4.0 (unlikely). In that case I would want this in the release. |
Member
Author
|
@cestella (or another PMC member) can you take a look at INFRA_14159? It is waiting on user right now. |
Contributor
|
@JonZeolla Sounds like Otto got his commit working. You should be good to try this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
I noticed there were some bugs rendering README.md files in GitHub MD, so I did a quick search by cloning the metron repo and then running
egrep -r "^#{1,6}[a-zA-Z]" * | grep -i README.md | cut -f1 -d\: | sort -ufrom the metron folder and then manually adding spaces between#symbols and the header text where necessary.Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.