Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@mattf-apache
Copy link
Member

Contributor Comments

Consistent with proposed post-release actions, incrementing the minor release number to 0.4.1, so that going forward, builds with additional commits cannot be mistaken for the recently released 0.4.0 release.

I built, ran all tests, and brought it up briefly in full-dev. Seems okay. Artifacts have appropriate version numbers.

Pull Request Checklist

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • [NA] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • [NA] Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • [NA] Have you written or updated unit tests and or integration tests to verify your changes?

  • [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book?

@ottobackwards
Copy link
Contributor

The site/current-book stuff should still refer to current project as 0.4.0?

@ottobackwards
Copy link
Contributor

+1 - searched, built, tests

@mattf-apache
Copy link
Member Author

@ottobackwards , thanks for the check. Re your question, that's correct, the "site" directory and the current-book it contains, should be for the current public site only, which is at 0.4.0.

@asfgit asfgit closed this in a8f3536 Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants