Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

METRON-1084: Management UI web server license should be Apache#683

Closed
merrimanr wants to merge 3 commits intoapache:masterfrom
merrimanr:METRON-1084
Closed

METRON-1084: Management UI web server license should be Apache#683
merrimanr wants to merge 3 commits intoapache:masterfrom
merrimanr:METRON-1084

Conversation

@merrimanr
Copy link
Contributor

Contributor Comments

Minor license correction.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@james-sirota
Copy link

+1

1 similar comment
@ottobackwards
Copy link
Contributor

+1

"private": true,
"author": "",
"license": "MIT"
"license": "Apache 2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://docs.npmjs.com/files/package.json and https://spdx.org/licenses/, it looks like this should probably be Apache-2.0 (with the dash). Is my understanding of this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@justinleet
Copy link
Contributor

+1

@merrimanr
Copy link
Contributor Author

@justinleet there are actually 2 package.json files in the management UI module. I just fixed the other one too. Can you check it out again?

@justinleet
Copy link
Contributor

@merrimanr Still +1, thanks for taking care of it

@asfgit asfgit closed this in de154b0 Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants