Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

METRON-1148: Add SET and MULTISET data structures to stellar#728

Closed
cestella wants to merge 4 commits intoapache:masterfrom
cestella:count_maps_for_stellar
Closed

METRON-1148: Add SET and MULTISET data structures to stellar#728
cestella wants to merge 4 commits intoapache:masterfrom
cestella:count_maps_for_stellar

Conversation

@cestella
Copy link
Copy Markdown
Member

@cestella cestella commented Sep 1, 2017

Contributor Comments

With the addition of geohashes, to do analytics like tracking the statistical distribution of the distances of a user's login against the centroid of the user logins across some time, there is a need to be able to store sets (e.g. sets of geohashes) and multisets (sets with multiplicity) in a way that they can be stored by the profiler and merged across time.
This JIRA should add:

  • SET_INIT
  • SET_ADD
  • SET_REMOVE
  • SET_MERGE
  • MULTISET_INIT
  • MULTISET_ADD
  • MULTISET_REMOVE
  • MULTISET_MERGE
  • MULTISET_TO_SET
    These follow the pattern of the other data structures (that are not stellar language primitives)

You can tinker with these in the stellar REPL as manual tests.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@ottobackwards
Copy link
Copy Markdown
Contributor

ottobackwards commented Sep 1, 2017

Thanks for the contribution! This looks really nice.
The question I have is the validation of parameters and the default return. With the FUZZY_SCORE effort, we discussed returning a default 0 score when input parameters where wrong, and changed so that errors in parameters where known. This seems to me to be kind of the same thing. If a non-iterable is passed, should it not be an error?

@cestella
Copy link
Copy Markdown
Member Author

cestella commented Sep 1, 2017

Which method are we talking about, @ottobackwards ?

@cestella
Copy link
Copy Markdown
Member Author

cestella commented Sep 1, 2017

Nevermind, I know what you're talking about now. Sorry, misunderstood :) Yeah, I'll do a quick check and ensure that exceptions are thrown where appropriate.

@cestella
Copy link
Copy Markdown
Member Author

cestella commented Sep 1, 2017

Ok, let me know if I missed any that you think should be there.

@ottobackwards
Copy link
Copy Markdown
Contributor

Thanks Casey, +1 by inspection

@asfgit asfgit closed this in 91a017b Sep 5, 2017
zezutom pushed a commit to zezutom/metron that referenced this pull request Sep 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants