This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-1162 Apply Live Messages to the Profile Debugger#736
Closed
nickwallen wants to merge 4 commits into
Closed
Conversation
…g required properties" This reverts commit 1cd5794.
cestella
reviewed
Sep 8, 2017
| * @param listOfStrings The function argument is a List of Strings. | ||
| * @return A list of messages. | ||
| */ | ||
| private List<JSONObject> getMessagesFromList(List<String> listOfStrings) { |
Member
There was a problem hiding this comment.
Just a very small nit, but could we make that an iterable instead of a List since that's all you really need? We now have SETs in stellar too and I think we may end up creating lazy iterable transformation functions too. (e.g. PROFILE_APPLY( LAZY_MAP( [ msg1, msg2 ], m -> REGEX_APPLY(...., m))
Contributor
Author
There was a problem hiding this comment.
Yes, that's better. Will do.
Member
|
+1 by inspection, lgtm! |
zezutom
pushed a commit
to zezutom/metron
that referenced
this pull request
Sep 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to be able to use
PROFILER_APPLYwith live messages from a Metron cluster. For example, I would like to be able to grab 10 messages from my production Metron and then apply them in my debugger. This would be tremendously helpful for iterating between the debugger and a live cluster when troubleshooting.The
PROFILER_APPLYfunction does not currently accept a list of messages. It accepts a String that is a JSON list, but not a Stellar list. ForPROFILER_APPLYto play happy withKAFKA_GET(and other potential uses) it needs to accept a List.This PR makes
PROFILER_APPLYrather flexible in the types of arguments that it accepts.Testing
This can be tested by launching the REPL and running the following.
Create a Profiler definition.
Create a sample message.
Initialize the Profiler.
Apply 3 messages at a time by passing in a list.