This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-1179: Make STATS_ADD to take a list#750
Closed
cestella wants to merge 4 commits intoapache:masterfrom
Closed
METRON-1179: Make STATS_ADD to take a list#750cestella wants to merge 4 commits intoapache:masterfrom
cestella wants to merge 4 commits intoapache:masterfrom
Conversation
| if( n != null) { | ||
| if(n instanceof Iterable) { | ||
| for(Object num : (Iterable<Object>)n) { | ||
| if(num != null) { |
Contributor
There was a problem hiding this comment.
Just a nit, but why 'double' and not Double?
Is there a reason to box?
| * Input: | ||
| * stats - The Stellar statistics object. If null, then a new one is initialized. | ||
| * value+ - One or more numbers to add | ||
| * value+ - One or more numbers to add. If one of objects is a list, it will iterate over the list and add each number. |
Contributor
There was a problem hiding this comment.
"One or more items to add. Each item may be a number or a list of numbers. If an item is a list, each number in the list will be added"?
Contributor
|
Looks great. Just a couple of nits, but otherwise LGTM +1. |
Member
Author
|
Ok, this is updated as per your comments, @ottobackwards |
Contributor
|
+1, thanks for the contribution and great work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
While we can add multiple values in
STATS_ADDviaSTATS_ADD(s, 1, 2, 3), but it'd be nice also to supportSTATS_ADD(s, [1, 2, 3])Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.