Simplify conditions and avoid extra compute. #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Arturo, for the OPTS_MLST patch, I think the logic would be to check if the returned array is not empty, and if so returning an error. The current code check if it's NULL but I think it's a mistake. So your suggestion is correct (logically) but I'd rather change the 'if' and keep it. |
Contributor
|
Hi Artur, it's more complicated that what I thought. Actually, the handling of the OPTS_MLST command is not properly done. Looking at the RFC, there are syntax errors that are not checked. Looking at, we should get an error when sending such a request:
Actually, we don't... |
Contributor
|
PR applied in 1.1.X branch (work in progress for 1.2.X) |
Contributor
|
PR applied in 1.2.X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.