This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.4.x] Fix gtest build#13926
Merged
lanking520 merged 1 commit intoapache:v1.4.xfrom Feb 14, 2019
Merged
Conversation
Contributor
|
@mxnet-label-bot add [pr-awaiting-review] |
Contributor
|
@ZhennanQin is this for master branch? |
Contributor
Author
|
@pengzhao-intel Master doesn't need this as master is still using old version of gtest. To avoid license issue, V1.4.x upgraded gtest and introduced this issue. |
Contributor
|
@marcoabreu @lebeg for review |
Contributor
|
@marcoabreu @lebeg Any concerns here with this PR for v1.4.x release ? |
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Feb 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments