This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Dynamically Generate Version Dropdown#18473
Merged
marcoabreu merged 4 commits intoapache:masterfrom Jun 3, 2020
Merged
Conversation
|
Hey @ys2843 , Thanks for submitting the PR
CI supported jobs: [edge, centos-gpu, website, unix-cpu, clang, miscellaneous, windows-cpu, centos-cpu, sanity, unix-gpu, windows-gpu] Note: |
Contributor
Author
|
@mxnet-label-bot update [website, pr-awaiting-review] |
marcoabreu
approved these changes
Jun 3, 2020
1 task
yijunc
pushed a commit
to yijunc/incubator-mxnet
that referenced
this pull request
Jun 9, 2020
* dynamically generate general version dropdown * dynamic generate installation guide version dropdown * fix type * use var Co-authored-by: Yang Shi <yangshia@amazon.com>
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
* dynamically generate general version dropdown * dynamic generate installation guide version dropdown * fix type * use var Co-authored-by: Yang Shi <yangshia@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To make several website version dropdowns more manageable and easier to update, this PR includes the change to dynamically generate all version dropdown using the
versionsconstant in_config.yml. This matches the implementation in global search #18288 (comment).Updated version dropdown in this PR:
Existing dynamically generate version dropdown:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments