Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] - Resources Downloaded over Insecure Protocol#19315

Open
b1nslashsh wants to merge 1 commit intoapache:v1.xfrom
b1nslashsh:patch-1
Open

[BUGFIX] - Resources Downloaded over Insecure Protocol#19315
b1nslashsh wants to merge 1 commit intoapache:v1.xfrom
b1nslashsh:patch-1

Conversation

@b1nslashsh
Copy link
Copy Markdown

@b1nslashsh b1nslashsh commented Oct 8, 2020

Description

This package is vulnerable to MITM or Man-In-The-Middle attack due to a downloading resources through insecure protocols. It is possible for an attacker to intercept and alter the packages which may leads to RCE other attacks which may help the attacker gain access to host

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

Just protocol changed to https and the resource is available in https.
in line https://github.com/apache/incubator-mxnet/blob/master/example/rnn/bucket_R/data_preprocessing_seq_to_one.R#L20

Comments

By switching to HTTPS that issue can be resolved.

@mxnet-bot
Copy link
Copy Markdown

Hey @b1nslashsh , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, edge, windows-cpu, unix-cpu, sanity, website, miscellaneous, clang, centos-gpu, centos-cpu, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@b1nslashsh b1nslashsh changed the title Update data_preprocessing_seq_to_one.R [BUGFIX] - Resources Downloaded over Insecure Protocol Oct 8, 2020
@leezu
Copy link
Copy Markdown
Contributor

leezu commented Oct 8, 2020

@mxnet-bot run ci [unix-gpu, windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-gpu, windows-gpu]

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 14, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 24, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 9, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 4, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-testing PR is reviewed and waiting CI build and test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants