[2.0.alpha] fixed backend_opts to be empty dictionary instead of None#19812
[2.0.alpha] fixed backend_opts to be empty dictionary instead of None#19812leezu merged 4 commits intoapache:masterfrom
Conversation
|
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [centos-cpu, unix-cpu, clang, website, unix-gpu, edge, windows-cpu, sanity, miscellaneous, centos-gpu, windows-gpu] Note: |
leezu
left a comment
There was a problem hiding this comment.
Thank you! Could you please add a test? It looks like this was completely untested?
Looking at the flow, it seems to only happen when calling And then the "clearing" sets the But in the unittests, we only use the So theres no way to duplicate exactly what is being done in the example. But, we do build the So we could add a test in unittests to use this library. But I think we decided not to do this in the past since people were running the unittests on pip wheels that didnt have the libraries packaged into the wheel. Thoughts? |
The CI does not use wheels for most pipelines AFAIK. You can just add a separate test folder and execute it manually in one of the CI pipelines? |
|
@mxnet-bot run ci [unix-cpu, windows-cpu, windows-gpu] |
|
Jenkins CI successfully triggered : [windows-gpu, windows-cpu, unix-cpu] |
I found a file |
Description
Fixes #19811