This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] Docker cache enhancements#20525
Merged
josephevans merged 8 commits intoapache:v1.xfrom Aug 13, 2021
Merged
Conversation
…ndwidth control, also parameterize the number of build retries and reduce from 10 to 1 for easier debugging.
… containers for the docker-compose based platforms. Add options for selecting architecture (defaults to x86) since aarch64 container builds will fail on x86 systems.
…e they are not built in docker_cache.py.
|
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [sanity, centos-cpu, miscellaneous, centos-gpu, windows-gpu, windows-cpu, unix-cpu, clang, edge, unix-gpu, website] Note: |
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-review
josephevans
added a commit
to josephevans/mxnet
that referenced
this pull request
Aug 18, 2021
* Properly initialize set so that docker cache builds exclude the centos7 dockerfile. * Change the number of parallel builds to 1 for easier debugging and bandwidth control, also parameterize the number of build retries and reduce from 10 to 1 for easier debugging. * Remove old dockerfiles. * Update docker-compose config to use new ECR-based naming scheme. * Refactor build.py and docker_cache.py to support building and pushing containers for the docker-compose based platforms. Add options for selecting architecture (defaults to x86) since aarch64 container builds will fail on x86 systems. * Remove old commands for building docker-compose based containers since they are not built in docker_cache.py. * Fix running of docker-compose based containers via build.py.
josephevans
added a commit
that referenced
this pull request
Aug 19, 2021
* [v1.x] Fix docker cache build pipeline (#20385) * libturbojpeg0-dev is only for ubuntu 18.04, so don't install on other ubuntu versions. * Change logic to not install on 16.04 (works on 18.04 and 20.04.) * Fix docker registry variable - was inadvertently changed to DOCKER_CACHE_REGISTRY from DOCKER_ECR_REGISTRY. * Use our local ECR registry for docker-compose images as well. * Revert changing DOCKER_CACHE_REGISTRY variable. * Override DOCKER_CACHE_REGISTRY for docker-compose in docker cache pipeline. * Login to ECR if using ECR for docker registry. * Import docker_cache when needed. * Add support for awscli v2, use docker credentials already saved from docker_cache.py run. (#20458) * [v1.x] Docker cache enhancements (#20525) * Properly initialize set so that docker cache builds exclude the centos7 dockerfile. * Change the number of parallel builds to 1 for easier debugging and bandwidth control, also parameterize the number of build retries and reduce from 10 to 1 for easier debugging. * Remove old dockerfiles. * Update docker-compose config to use new ECR-based naming scheme. * Refactor build.py and docker_cache.py to support building and pushing containers for the docker-compose based platforms. Add options for selecting architecture (defaults to x86) since aarch64 container builds will fail on x86 systems. * Remove old commands for building docker-compose based containers since they are not built in docker_cache.py. * Fix running of docker-compose based containers via build.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor docker_cache.py and build.py to support docker-compose based containers.