Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] LICENSE and CI fixes for 1.9 release#20626

Merged
josephevans merged 24 commits intoapache:v1.9.xfrom
josephevans:license_fixes4_v1.9.x
Oct 7, 2021
Merged

[v1.9.x] LICENSE and CI fixes for 1.9 release#20626
josephevans merged 24 commits intoapache:v1.9.xfrom
josephevans:license_fixes4_v1.9.x

Conversation

@josephevans
Copy link
Copy Markdown
Contributor

@josephevans josephevans commented Oct 1, 2021 •
edited
Loading

Update LICENSE to include symlinks in include/dmlc licensed under non-ASF-2.0 licenses.

Fix docker build issues with Let's Encrypt CA expiration.

Fix perl package dependency issue with PDL.

Part of #20616

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Oct 1, 2021

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, centos-cpu, website, windows-cpu, miscellaneous, edge, unix-cpu, clang, windows-gpu, unix-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 1, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 2, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 2, 2021
@josephevans josephevans changed the title [v1.9.x] Update LICENSE [v1.9.x] LICENSE and CI fixes for 1.9 release Oct 2, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 2, 2021
@josephevans josephevans requested a review from barry-jin October 2, 2021 04:36
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 2, 2021
@josephevans josephevans mentioned this pull request Oct 6, 2021
Closed
6 tasks
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 6, 2021
waytrue17
waytrue17 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fixes!

@josephevans josephevans mentioned this pull request Oct 7, 2021
Closed
6 tasks
@josephevans
Back off retry count for windows builds to reduce cost.
98bbcae
@josephevans
Split test_hybrid_static_memory_switching() into 3 tests in order to …
23db9ba 
…isolate failures.
@josephevans
Skip mkldnn test, tracking at apache#20643.
f45a6e3
@josephevans
Fix lint
34b430c
@josephevans
Attempt to fix windows build parameters with MKLDNN builds - do not u…
b64dd38 
…se debug builds when linking against MKLDNN.
@josephevans
Revert "Update ca-certificates package on centos7 due to let's encryp…
7bbfd9c 
…t recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4)"

This reverts commit 8b64859.
@josephevans
Add back change after revert.
4b947fd
@josephevans
Revert "Fix lint"
c1005c2 
This reverts commit 34b430c.
@josephevans
Revert "Skip mkldnn test, tracking at apache#20643."
4f7ad51 
This reverts commit f45a6e3.
@josephevans
Revert "Split test_hybrid_static_memory_switching() into 3 tests in o…
780c3ea 
…rder to isolate failures."

This reverts commit 23db9ba.
@josephevans
Revert changing windows build flags.
acdef19
@bartekkuncer
Copy link
Copy Markdown
Contributor

bartekkuncer commented Oct 7, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Oct 7, 2021

Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.

@josephevans josephevans mentioned this pull request Oct 7, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

2 more reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@barry-jin barry-jin barry-jin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@josephevans @mxnet-bot @bartekkuncer @waytrue17 @barry-jin @mseth10