Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Fix for fc with sum when types are incompatible#21042

Merged
bgawrych merged 3 commits intoapache:v1.xfrom
DominikaJedynak:fc_add_types_fix
Jul 20, 2022
Merged

[v1.x] Fix for fc with sum when types are incompatible#21042
bgawrych merged 3 commits intoapache:v1.xfrom
DominikaJedynak:fc_add_types_fix

Conversation

@DominikaJedynak
Copy link
Copy Markdown
Contributor

@DominikaJedynak DominikaJedynak commented May 26, 2022

Description

This PR fixes the problem occurring when data_2, which is to be added to quantized fc output, happens to be all non-negative (and treated as u8) while fc output is s8. In this situation, data_2 will be rescaled to s8 as well to prevent truncation of fc output.
This change also prevents the situation when fc output is u8 and data_2 is s8.

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 26, 2022

Hey @DominikaJedynak , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, website, windows-cpu, unix-cpu, unix-gpu, clang, miscellaneous, centos-gpu, sanity, windows-gpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 26, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented May 27, 2022

@mxnet-bot run ci [centos-gpu, centos-cpu, clang, unix-cpu, website]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 27, 2022

Jenkins CI successfully triggered : [website, centos-gpu, centos-cpu, clang, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 27, 2022
@DominikaJedynak DominikaJedynak changed the title Fix for fc with sum when types are incompatible [v1.x] Fix for fc with sum when types are incompatible May 27, 2022
@DominikaJedynak DominikaJedynak mentioned this pull request May 27, 2022
Merged
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 27, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented May 28, 2022

@mxnet-bot run ci [centos-cpu, edge, unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 28, 2022

Jenkins CI successfully triggered : [edge, unix-gpu, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 28, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented May 28, 2022

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 28, 2022

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 28, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented May 29, 2022

@mxnet-bot run ci [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 30, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented Jun 30, 2022

@mxnet-bot run ci [centos-cpu, unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jun 30, 2022

Jenkins CI successfully triggered : [unix-gpu, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 30, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented Jul 12, 2022

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jul 12, 2022

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 12, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented Jul 12, 2022

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jul 12, 2022

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 12, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented Jul 13, 2022

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jul 13, 2022

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 13, 2022
@DominikaJedynak
Copy link
Copy Markdown
Contributor Author

DominikaJedynak commented Jul 19, 2022

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jul 19, 2022

Jenkins CI successfully triggered : [unix-gpu]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bgawrych bgawrych bgawrych approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DominikaJedynak @mxnet-bot @bgawrych @mseth10