Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Enable DTypes in deconvolution#2322

Merged
tqchen merged 1 commit intoapache:masterfrom
oist:vc/dtype_deconv
Jun 8, 2016
Merged

Enable DTypes in deconvolution#2322
tqchen merged 1 commit intoapache:masterfrom
oist:vc/dtype_deconv

Conversation

@vchuravy
Copy link
Contributor

@vchuravy vchuravy commented Jun 3, 2016

Ref #2302

@piiswrong
Copy link
Contributor

could you add a type consistency check in tests/python/gpu/test_operator_gpu.py?

@piiswrong
Copy link
Contributor

otherwise lgtm

@vchuravy vchuravy force-pushed the vc/dtype_deconv branch 2 times, most recently from 120260e to 4f48838 Compare June 3, 2016 07:52
@vchuravy
Copy link
Contributor Author

vchuravy commented Jun 3, 2016

done.

@vchuravy
Copy link
Contributor Author

vchuravy commented Jun 6, 2016

rebased and ready to merge.

@piiswrong
Copy link
Contributor

Need to rebase again...
Linear merging is indeed becoming a problem

@vchuravy vchuravy changed the title Enable DTypes in decovolution Enable DTypes in deconvolution Jun 7, 2016
@vchuravy
Copy link
Contributor Author

vchuravy commented Jun 7, 2016

Yes it indeed is. It especially slows you down if you are in a different timezone, than the majority of people with merge rights.

@vchuravy
Copy link
Contributor Author

vchuravy commented Jun 7, 2016

@piiswrong rebased

@piiswrong
Copy link
Contributor

@tqchen good for merging after test finishes

@tqchen tqchen merged commit 8e7515b into apache:master Jun 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants