This repository was archived by the owner on Nov 17, 2023. It is now read-only.
DType support#2559
Closed
Godricly wants to merge 7 commits intoapache:masterfrom
Godricly:fp16_support
Closed
Conversation
using default float, double for their own initialization. The other types use values which are cast from float type.
| tmp = empty(out.shape, out.ctx) | ||
| tmp = NDArray._sample_normal(loc=loc, scale=scale, shape=out.shape, out=tmp) | ||
| out[:] = tmp | ||
| return out |
Member
There was a problem hiding this comment.
Have we missed an else above?
Contributor
Author
There was a problem hiding this comment.
ah...yes...sry for that....I manually typed my code here..
| # currently, input_types is not passed in | ||
| if input_types is None: | ||
| input_types = {k : mx_real_t for k in input_shapes.keys()} | ||
| arg_types, _, aux_types = self.symbol.infer_type(**input_types) |
Member
There was a problem hiding this comment.
We'd better make sure that the change here does not affect other existing examples (like image classification and LSTM).
Contributor
Author
There was a problem hiding this comment.
It should be ok as default infer_type gives float type.
Member
|
get_random currently will fail under current resource manager. Need to modify the resource manager in order to support this. So let us remove random support for now and make it a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init_param is changed to support DType.