Conversation
|
@piiswrong could you please check python side code, i.e. example/caffe/caffe_net.py? |
plugin/caffe/caffe_op-inl.h
Outdated
| DMLC_DECLARE_FIELD(in_num).set_range(0, 100).set_default(1) | ||
| DMLC_DECLARE_FIELD(data_num).set_range(0, 100).set_default(1) | ||
| .describe("Operator input number"); | ||
| DMLC_DECLARE_FIELD(w_num).set_range(0, 100).set_default(0) |
There was a problem hiding this comment.
change to num_weight
|
data=[data0, data1, data2] is equivalent to *[data0, data1, data2]. Other than that its good. PS. also please rebase to master |
|
LGTM. Fix lint and we can merge. This is a great effort. Thanks so much for doing this. |
|
Fixed the lint and complement the patch in caffe docs. |
|
Hopefully the test will pass and I'll merge it You can add more features in new PRs |
|
@HrWangChengdu Because I created this pull request for you, the commit history now traces this to me. You can make a new PR with two commits where the first one removes every file you added in this PR and the second one adds them back in, so that the history will be traced to you. |
|
you can revert this pr... |
|
How? I probably don't have the privilige |
|
@mli I can't do forced push. Can you? Discard the last commit? |
|
forced push is disabled, which is too dangers. there is a revert button in On Tue, Jul 26, 2016 at 10:17 PM, Eric Junyuan Xie <notifications@github.com
|
|
I have created a revert PR |
|
Should I new a PR after the revert one is done? |
|
Yes, Please PR again |
|
Just create one #2854 |
|
It is great that this is merged in. Let us work on making the blogpost to dmlc.ml and put this on the news |
5 participants
@HrWangChengdu I helped you created this pull request to track progress and make some comments.