This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Quantization] ops: 'quantize', 'dequantize'#5843
Merged
piiswrong merged 11 commits intoapache:masterfrom Apr 26, 2017
ZihengJiang:quantization
Merged
[Quantization] ops: 'quantize', 'dequantize'#5843piiswrong merged 11 commits intoapache:masterfrom ZihengJiang:quantization
piiswrong merged 11 commits intoapache:masterfrom
ZihengJiang:quantization
Conversation
piiswrong
reviewed
Apr 15, 2017
src/operator/contrib/dequantize.cc
Outdated
| DMLC_REGISTER_PARAMETER(DequantizeParam); | ||
|
|
||
| NNVM_REGISTER_OP(_contrib_dequantize) | ||
| .MXNET_DESCRIBE("Dequantize") |
Contributor
There was a problem hiding this comment.
add some document describing the math and reference papers.
piiswrong
reviewed
Apr 15, 2017
| struct DequantizeParam : public dmlc::Parameter<DequantizeParam> { | ||
| float min_range; | ||
| float max_range; | ||
| int out_type; |
Contributor
There was a problem hiding this comment.
arguments looks verbose. min, max, dtype looks better
Guneet-Dhillon
pushed a commit
to Guneet-Dhillon/mxnet
that referenced
this pull request
Sep 13, 2017
* [Quantization] ops: 'quantize', 'dequantize' * [Quantization] Add description * Fix macro * Fix macro * [Quantization] Refine interface * [Quantization] Fix lint * Fix GPU version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it public for other guys to contribute and use.
@mli @thatindiandude @arank