Add test for pip installations#5916
Conversation
sandeep-krishnamurthy
left a comment
sandeep-krishnamurthy
left a comment
There was a problem hiding this comment.
Great. Thanks for this changes. Overall looks good.
Few queries posted as comment.
I am guessing that we will be running this as nightly tests and not for each PR?
If nightly I am good to have that failing test at the end to get started off.
|
|
||
| # add repo to install different Python versions | ||
| RUN apt-get update && apt-get install -y software-properties-common | ||
| RUN add-apt-repository ppa:fkrull/deadsnakes && apt-get update |
There was a problem hiding this comment.
This repository has a lot of old/new Python versions to test with. This allows me to install multiple versions of Python 3.
| cp ${DOCKERFILE_DEVICE} ${DOCKERFILE} | ||
| cat Dockerfile.pip_dependencies >> ${DOCKERFILE} | ||
|
|
||
| # build Docker image |
There was a problem hiding this comment.
Why do we want to build docker image every time?
There was a problem hiding this comment.
- It can rebuild if we've made changes to the Dockerfile
- We don't assume that the image exists on the host
- We don't have to rely on Dockerhub/ECS and push small images that we only use for testing purposes
What's nice about this is that if we've rerun this test in succession, the image built the first time is cached, so we don't spend additional time rebuilding.
|
nosetest failing possibly because I added arguments to the test_conv.py script. Debugging and will push the changes after. |
|
@szha should we put the pip tests into the pip build repo? |
|
It would be nice to include tests after the build of each variation. The blocker was the Travis build time-limit. We will need to move the release to Jenkins if we want tests like this pr. Currently I manually test all the releases with unit tests. |
|
if we have mac on Jenkins we can move the release to Jenkins |
|
@mli @szha @piiswrong we don't have mac on Jenkins right now and can't prioritize adding that. Can we push this for now so we can run a nightly test? I can organize this test script under tests/jenkins/pip/ folder if that helps. |
* Clean install script * Add test for pip installations * Remove debug statements & comments * Make test runnable as script and from framework
5 participants
This commit adds Dockerfiles and test script to test all variants of MXNet pip packages. I've tested this on a copy of the Jenkins slave host with an updated NVIDIA driver (375.26) with the following command:
tests/jenkins/run_test_pip_installations.sh ${WORKSPACE}where WORKSPACE was set to /home/ec2-user/mxnet, the Jenkins workspace.Currently the test will fail after testing
mxnetwith Python 3.6 as the accuracy is lower than expected. We can either put that case at the very end or change the script to not fail until all cases have been tested.@sandeep-krishnamurthy