Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

fix UnicodeDecodeError#5920

Merged
piiswrong merged 2 commits intoapache:masterfrom
kice:master
Apr 21, 2017
Merged

fix UnicodeDecodeError#5920
piiswrong merged 2 commits intoapache:masterfrom
kice:master

Conversation

@kice
Copy link
Copy Markdown
Contributor

@kice kice commented Apr 20, 2017

Remove unexpected character

Remove unexpected character
@kice
Copy link
Copy Markdown
Contributor Author

kice commented Apr 20, 2017

Issue: #5848

fix another file beside #5908

@piiswrong
Copy link
Copy Markdown
Contributor

@mli @zackchase Can we enforce some kind of unicode check in lint?

@kice
Copy link
Copy Markdown
Contributor Author

kice commented Apr 20, 2017

Maybe we can look every byte to check if it is Printable characters (and maybe include TAB character)?

https://en.wikipedia.org/wiki/ASCII#Printable_characters

@yajiedesign
Copy link
Copy Markdown
Contributor

good.I changed this file but forgot to submit it in #5908

@piiswrong piiswrong merged commit f613e29 into apache:master Apr 21, 2017
Guneet-Dhillon pushed a commit to Guneet-Dhillon/mxnet that referenced this pull request Sep 13, 2017
Remove unexpected character
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants