change * in layout manager by JasminKroeger · Pull Request #70 · apache/myfaces-tobago

JasminKroeger · 2020-04-15T09:58:59Z

change * for example to 1fr

henningn

There are still a view descriptions that contain a '*' instead of 'fr':

SegmentLayoutTagDeclaration
GridLayoutTagDeclaration (see line 47)
Flex_Layout.xhtml
Split_Layout.xhtml

Maybe you can improve those too.

henningn

I've overlooked that there are descriptions where the tokens are semicolon separated. But they are space separated now.
You can find these descriptions in:

FlexLayoutTagDeclaration
GridLayoutTagDeclaration (line 43)
SplitLayoutTagDeclaration
Flex_Layout.xhtml

henningn · 2020-04-17T14:54:09Z

@@ -57,7 +57,7 @@ public interface SegmentLayoutTagDeclaration extends HasIdBindingAndRendered, Is
  /**
   * The space-separated definition of the columns for extra small devices.
   * Possible values are: segment values between 1 and 12, 'auto' and '*'.


replace unit '*' with 'fr'

henningn · 2020-04-17T14:54:18Z

@@ -66,7 +66,7 @@ public interface SegmentLayoutTagDeclaration extends HasIdBindingAndRendered, Is
  /**
   * The space-separated definition of the columns for small devices.
   * Possible values are: segment values between 1 and 12, 'auto' and '*'.


replace unit '*' with 'fr'

henningn · 2020-04-17T14:54:26Z

@@ -75,7 +75,7 @@ public interface SegmentLayoutTagDeclaration extends HasIdBindingAndRendered, Is
  /**
   * The space-separated definition of the columns for medium devices.
   * Possible values are: segment values between 1 and 12, 'auto' and '*'.


replace unit '*' with 'fr'

henningn · 2020-04-17T14:54:32Z

@@ -84,7 +84,7 @@ public interface SegmentLayoutTagDeclaration extends HasIdBindingAndRendered, Is
  /**
   * The space-separated definition of the columns for large devices.
   * Possible values are: segment values between 1 and 12, 'auto' and '*'.


replace unit '*' with 'fr'

henningn · 2020-04-17T14:54:41Z

@@ -93,7 +93,7 @@ public interface SegmentLayoutTagDeclaration extends HasIdBindingAndRendered, Is
  /**
   * The space-separated definition of the columns for extra large devices.
   * Possible values are: segment values between 1 and 12, 'auto' and '*'.


replace unit '*' with 'fr'

henningn · 2020-04-17T15:07:02Z

 public class SplitLayoutController implements Serializable {

-  private String horizontalLayout = "1*;1*";
+  private String horizontalLayout = "1fr;1fr";


make is space separated

henningn · 2020-04-21T09:47:47Z

   * The space-separated definition of the columns for extra small devices.
-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.


In JavaDoc you can write HTML. Therefore HTML brackets have to be escaped.

henningn · 2020-04-21T09:47:56Z

   * The space-separated definition of the columns for small devices.
-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.


In JavaDoc you can write HTML. Therefore HTML brackets have to be escaped.

henningn · 2020-04-21T09:48:37Z

-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.
+   * Example: '1seg 5seg fr auto'


'fr' is without a number.

henningn · 2020-04-21T09:48:52Z

-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.
+   * Example: '1seg 5seg fr auto'


'fr' without a number

henningn · 2020-04-21T09:48:57Z

   * The space-separated definition of the columns for medium devices.
-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.


In JavaDoc you can write HTML. Therefore HTML brackets have to be escaped.

henningn · 2020-04-21T09:49:21Z

-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.
+   * Example: '1seg 5seg fr auto'


'fr' without a number

henningn · 2020-04-21T09:49:27Z

   * The space-separated definition of the columns for extra large devices.
-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.


In JavaDoc you can write HTML. Therefore HTML brackets have to be escaped.

henningn · 2020-04-21T09:49:36Z

-   * Possible values are: segment values between 1 and 12, 'auto' and '*'.
-   * Example: '1seg 5seg * auto'
+   * Possible values are: [1-12]seg, 'auto' and <n>fr.
+   * Example: '1seg 5seg fr auto'


'fr' without a number

henningn · 2020-04-21T09:50:26Z

+   * It is a semicolon separated list of layout tokens '&lt;n&gt;fr', '&lt;measure&gt;' or the keyword 'auto'.
   * Where &lt;n&gt; is a positive integer or empty and &lt;measure&gt; is a valid CSS length.
-   * Example: '2*;*;100px;3rem;auto'.
+   * Example: '2fr fr 100px 3rem auto'.


'fr' without a number

henningn · 2020-04-21T09:50:31Z

+   * It is a space separated list of layout tokens '&lt;n&gt;fr', '&lt;measure&gt;' or the keyword 'auto'.
   * Where &lt;n&gt; is a positive integer or empty and &lt;measure&gt; is a valid CSS length.
-   * Example: '2*;*;100px;3rem;auto'.
+   * Example: '2fr fr 100px 3rem auto'.


'fr' without a number

henningn · 2020-04-22T13:01:19Z

  /**
   * This value defines the layout constraints for column layout.
-   * It is a semicolon separated list of layout tokens '&lt;n&gt;*', '&lt;measure&gt;' or the keyword 'auto'.
+   * It is a semicolon separated list of layout tokens '&lt;n&gt;1fr', '&lt;measure&gt;' or the keyword 'auto'.


henningn · 2020-04-22T13:01:27Z

  /**
   * This value defines the layout constraints for row layout.
-   * It is a semicolon separated list of layout tokens '&lt;n&gt;*', '&lt;measure&gt;' or the keyword 'auto'.
+   * It is a semicolon separated list of layout tokens '&lt;n&gt;1fr', '&lt;measure&gt;' or the keyword 'auto'.


henningn · 2020-04-22T13:03:52Z

   * This value defines the layout constraints for column layout.
-   * It is a semicolon separated list of layout tokens '&lt;n&gt;*', '&lt;measure&gt;' or the keyword 'auto'.
+   * It is a semicolon separated list of layout tokens '&lt;n&gt;1fr', '&lt;measure&gt;' or the keyword 'auto'.
   * Where &lt;n&gt; is a positive integer or empty and &lt;measure&gt; is a valid CSS length.


must be a positive integer

henningn · 2020-04-22T13:04:00Z

   * This value defines the layout constraints for row layout.
-   * It is a semicolon separated list of layout tokens '&lt;n&gt;*', '&lt;measure&gt;' or the keyword 'auto'.
+   * It is a semicolon separated list of layout tokens '&lt;n&gt;1fr', '&lt;measure&gt;' or the keyword 'auto'.
   * Where &lt;n&gt; is a positive integer or empty and &lt;measure&gt; is a valid CSS length.


must be a positive integer

henningn · 2020-04-22T13:04:18Z

   * This value defines the layout constraints for column layout.
-   * It is a semicolon separated list of layout tokens '&lt;n&gt;*', '&lt;measure&gt;' or the keyword 'auto'.
+   * It is a space separated list of layout tokens '&lt;n&gt;fr', '&lt;measure&gt;' or the keyword 'auto'.
   * Where &lt;n&gt; is a positive integer or empty and &lt;measure&gt; is a valid CSS length.


must be a positive integer

henningn · 2020-04-22T13:04:24Z

   * This value defines the layout constraints for row layout.
-   * It is a semicolon separated list of layout tokens '&lt;n&gt;*', '&lt;measure&gt;' or the keyword 'auto'.
+   * It is a space separated list of layout tokens '&lt;n&gt;fr', '&lt;measure&gt;' or the keyword 'auto'.
   * Where &lt;n&gt; is a positive integer or empty and &lt;measure&gt; is a valid CSS length.


must be a positive integer

* change * for example to 1fr

henningn · 2020-05-07T12:07:44Z

Commited with some changes. See: 50e075d

henningn self-requested a review April 17, 2020 07:45

henningn self-assigned this Apr 17, 2020

henningn added the enhancement label Apr 17, 2020

henningn requested changes Apr 17, 2020

View reviewed changes

JasminKroeger force-pushed the changeLayout branch from 4cecc34 to 9b11477 Compare April 17, 2020 08:41

henningn self-requested a review April 17, 2020 14:02

henningn requested changes Apr 17, 2020

View reviewed changes

JasminKroeger force-pushed the changeLayout branch 2 times, most recently from 17255d2 to 4c170ad Compare April 20, 2020 09:43

henningn self-requested a review April 21, 2020 07:44

henningn requested changes Apr 21, 2020

View reviewed changes

JasminKroeger force-pushed the changeLayout branch 2 times, most recently from f244e36 to ac79c08 Compare April 21, 2020 19:21

henningn self-requested a review April 22, 2020 12:54

henningn requested changes Apr 22, 2020

View reviewed changes

Jasmin Kroeger added 2 commits April 22, 2020 16:57

change * in layout manager

f1f8fdc

* change * for example to 1fr

change * in layout manager

5f9160f

JasminKroeger force-pushed the changeLayout branch from ac79c08 to 5f9160f Compare April 22, 2020 15:03

henningn self-requested a review April 23, 2020 16:14

henningn closed this May 7, 2020

JasminKroeger deleted the changeLayout branch May 8, 2020 14:30

Uh oh!

Conversation

JasminKroeger commented Apr 15, 2020

Uh oh!

henningn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

henningn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henningn commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants