Disable the parsing of external general entities and external paramet…#153
Merged
bohmber merged 3 commits intoapache:masterfrom Jan 22, 2021
Merged
Disable the parsing of external general entities and external paramet…#153bohmber merged 3 commits intoapache:masterfrom
bohmber merged 3 commits intoapache:masterfrom
Conversation
…er entities in XML parsing code
…er entities in XML parsing code
…er entities in XML parsing code
Member
|
Could this break something? |
Contributor
Author
|
adding
would break. The rest is from here https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html I checked other apache projects many of them doing the same |
Member
|
then +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er entities in XML parsing code
https://issues.apache.org/jira/browse/MYFACES-4377