MYFACES-4445: websockets refactoring #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
milansie
commented
Oct 1, 2022
milansie
commented
- reworked channel token generation - new token is generated only if needed (ie new session/view), just one token for application scope
- fixed usage of user-specified channel - now also works even in application scope calls
- changed default max idle timeout for websockets - according to omnifaces/mojarra spec
- specified default websocket scope - according to documentation (session scope for user-specified websocket as default)
- reworked channel token generation - new token is generated only if needed (ie new session/view), just one token for application scope - fixed usage of user-specified channel - now also works even in application scope calls - changed default max idle timeout for websockets - according to omnifaces/mojarra spec - specified default websocket scope - according to documentation (session scope for user-specified websocket as default)
Member
|
can anyone review, too? |
Member
|
also we need to port the changes then to 4.0 @milansie, if everyone is ok with it |
Contributor
Author
|
i'm ready to port the changes to version 4.0 as soon as the changes are confirmed. |
melloware
approved these changes
Oct 6, 2022
Contributor
|
These look good to me I am going to merge this and @milansie you can work on the 4.0 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.