MYFACES-4273 close() JarFile in Classpath#34
Merged
wtlucy merged 1 commit intoapache:masterfrom Dec 10, 2018
Merged
Conversation
Member
|
basically +1 |
wtlucy
force-pushed
the
ClasspathFileLeak
branch
from
68346cb to
b3320e2
Compare
Contributor
Author
|
@tandraschko how's this? I'll still need to use the try finally method for the 2.0 and 2.1 branches |
Member
|
looks good if it still works the same :) |
Contributor
Author
|
Yeah, it's the same logic. I'll put this fix in 2.2, 2.3, and 3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/MYFACES-4273