Merged
Conversation
volosied
force-pushed
the
myfaces-4311-unit-tests
branch
from
e651ced to
7ee0597
Compare
volosied
force-pushed
the
myfaces-4311-unit-tests
branch
from
7ee0597 to
bdc2a01
Compare
Contributor
|
This looks good @volosied, thanks for circling back to add these tests. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two unit tests to ensure that the generic converter & validator work as expected.
And let me know if there are any issues. Particularly, I'm not sure if I should implement testValidator another way. I kept it simple with the try catch, but I can use some JUnit feature to expect a FacesException if recommended.
Tested issue:
https://issues.apache.org/jira/browse/MYFACES-4311
#75