Skip to content

MYFACES-4749: Ts6 Update and fixes in the areas of HTTP 404, Websocket and Fileupload, Code improvements in core classes, lots of new tests#986

Merged
werpu merged 8 commits intoapache:mainfrom
werpu:main
May 5, 2026

Conversation

@werpu
Copy link
Copy Markdown
Contributor

@werpu werpu commented May 3, 2026

@werpu
Copy link
Copy Markdown
Contributor Author

werpu commented May 3, 2026

guys since this is a significant update in the Ajax codebase with various fixes especially in the Websocket area, please give this code a try, I will start to commit it as soon as you guys greenlight it! Areas to test specifically are push and the fileupload both have gotten bugfixes, the rest is mostly code beautification covered by tests either existing or written before the refactoring!

Tobago already passes!

Also note with the commit, this is the first significant commit in the codebase where AI tooling was applied as co helper, everything is in accordance with the ASF guidelines!

@werpu werpu changed the title MYFACES-4749: Ts6 Update and fixes MYFACES-4749: Ts6 Update and fixes in the areas of HTTP 404, Websocket and Fileupload, Code improvements in core classes, lots of new tests May 3, 2026
Copy link
Copy Markdown
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

@werpu
Copy link
Copy Markdown
Contributor Author

werpu commented May 4, 2026

If anyone still wants to pretest this please drop a note otherwise I will start the merges tomorrow!

@volosied volosied self-requested a review May 4, 2026 20:11
Copy link
Copy Markdown
Contributor

@volosied volosied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do testing after we merge. This is progress none the less.

(I'll try to create a script for myself to make it easier to run the TCK.)

@werpu
Copy link
Copy Markdown
Contributor Author

werpu commented May 4, 2026

Ok perfect, I will do the merges tomorrow then, it is getting late over here.
Thanks for the feedback!

@werpu werpu merged commit dc1d1e4 into apache:main May 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants