sensor_shell: Fix shell to not remove event from default queue #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not use console_read() for expecting characters from the console - added a new command `sensor read_stop` to stop an infinite read - instead of using a while loop, changed sensor shell to be event based
ccollins476ad
approved these changes
Sep 1, 2018
Contributor
ccollins476ad
left a comment
ccollins476ad
left a comment
There was a problem hiding this comment.
Looks good to me. You might want to prevent the user from starting a second read while one is already in progress.
vrahane
force-pushed
the
sensor_shell_fix_event
branch
from
b7b35e9 to
3f09818
Compare
Contributor
Author
|
Thanks @ccollins476ad, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sensor read_stopto stop an infinite read