hw/mcu/da1469x: hal_flash manual mode enhanced#1990
Merged
kasjer merged 1 commit intoapache:masterfrom Nov 7, 2019
Merged
Conversation
andrzej-kaczmarek
approved these changes
Sep 6, 2019
kasjer
force-pushed
the
kasjer/da1469x-enhance-hal_flash
branch
from
716eb24 to
c1073ec
Compare
- returning to automode is done by restoring original value of QSPIC_CTRLMODE_REG. This will take care of correct bus width and D2 D3 lines state. There is no automatic switch to quad mode any more. - switching to manual mode sequence of call was made: da1469x_qspi_mode_manual() da1469x_qspi_mode_single() now da1469x_qspi_mode_manual() will automatically switch to single mode and additionally it will send break sequence that should end any continues read mode. previous code sent only one byte in single mode that is not enough to leave dual continuous read. - da1469x_qspi_mode_dual() and da1469x_qspi_mode_single() now setup controller in requested state without sending break sequence that was sent when manual mode was entered.
kasjer
force-pushed
the
kasjer/da1469x-enhance-hal_flash
branch
from
c1073ec to
d3500ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QSPIC_CTRLMODE_REG. This will take care of correct bus width
and D2 D3 lines state. There is no automatic switch to quad mode
any more.
da1469x_qspi_mode_manual()
da1469x_qspi_mode_single()
now da1469x_qspi_mode_manual() will automatically switch to single mode
and additionally it will send break sequence that should end any
continues read mode.
previous code sent only one byte in single mode that is not enough
to leave dual continuous read.
controller in requested state without sending break sequence that
was sent when manual mode was entered.