[WIP - DO NOT MERGE] encoding/tinycbor: Break up cbor header#2084
Closed
vrahane wants to merge 1 commit intoapache:masterfrom
Closed
[WIP - DO NOT MERGE] encoding/tinycbor: Break up cbor header#2084vrahane wants to merge 1 commit intoapache:masterfrom
vrahane wants to merge 1 commit intoapache:masterfrom
Conversation
- Breaking up cbor header file to cbor_decoder_reader.h and cbor_encoder_writer.h
vrahane
force-pushed
the
break_up_cbor_headers
branch
from
e730214 to
22d53cc
Compare
Contributor
Author
|
@de-nordic Can I close this PR ? I think this is not needed. |
|
Yes, you may close it. Thanks. |
Contributor
|
It looks like everyone agrees this should be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and cbor_encoder_writer.h
@sterlinghughes @mlaz @carlescufi @de-nordic
I have just made the change as a place holder and tested it out but I don't think this is necessary for Zephyr in anyway. Can we ask Dominik to take a look. If this is not required, I would like to not make this change at all in mynewt-core.