Fixes for ina219/ina226 #3225
Merged
Fixes for ina219/ina226 #3225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasjer
force-pushed
the
kasjer/ina2xx-fixes
branch
2 times, most recently
from
216e5ec to
d1c2f02
Compare
Contributor
Author
|
Stats indent complain is not worth fixing. Style checker should be updated if anyone can do this. |
kasjer
force-pushed
the
kasjer/ina2xx-fixes
branch
from
d1c2f02 to
10cdc59
Compare
For voltage calculation wrong bit was tested to see if range is 16 or 32V. This could resulted in incorrect value being computed depending if BRNG bit was matching bit from BG. mcu/pic32: Add minimal boot code There is special flash area dedicated to bootloader (0xbfc00000-0xbfc0FF00). Code from this area is execute first. This is where mcuboot is placed. It is possible to build application elf that provides minimal code that jumps to normal flash area dedicated for applications. The elf generated this way can then easyly be used in MPLAB X ide instead of command line gdb. When syscfg has MCU_NO_BOOTLOADER_BUILD set to 1 additional section is generated that goes to bootloader area of MCU. mcu/pic32: Add minimal boot code There is special flash area dedicated to bootloader (0xbfc00000-0xbfc0FF00). Code from this area is execute first. This is where mcuboot is placed. It is possible to build application elf that provides minimal code that jumps to normal flash area dedicated for applications. The elf generated this way can then easyly be used in MPLAB X ide instead of command line gdb. When syscfg has MCU_NO_BOOTLOADER_BUILD set to 1 additional section is generated that goes to bootloader area of MCU.
Warning are false positive but code is changed anyway.
kasjer
force-pushed
the
kasjer/ina2xx-fixes
branch
from
10cdc59 to
6aef91e
Compare
sjanc
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both drivers shell code has warning in new compilers
For INA219 voltage calculation was not correct for 32V or 16V range depending on
random bit.