Give HCI socket transport its own task.#384
Merged
Merged
Conversation
This prevents deadlock while the host waits for a command-complete event from the controller.
mkiiskila
approved these changes
Jul 7, 2017
Contributor
mkiiskila
left a comment
mkiiskila
left a comment
There was a problem hiding this comment.
I guess the earlier fix required user to create the 2nd task in the app itself. This change should be fine; transport/socket is only used with native builds, and there we're not constrained resource-wise.
rymanluk
approved these changes
Jul 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents deadlock while the host waits for a command-complete event from the controller. This is a slightly modified patch written by @rymanluk (changes include: adding a few syscfg settings, minor renames).