Merged
Conversation
The radio events used to do most of their work inside an isr. Now, they post events to the lora mac task and the mac task handles them.
Contributor
|
something is not right with second commit message :) |
Author
|
I think I see what you mean regarding second commit message. There are additional changes to be made so will update this PR... |
added 2 commits
August 31, 2017 11:02
Modify all remaining routines that performed work inside an ISR so that they post to the lora mac task instead of doing things within an ISR. Added statistics for lora mac Modified how the code deals with determining when a transmission is finished. No more mac state check timer.
Modify lora mac stack and sx1276 driver to use a dedicated timer instead of os cputime. The main reason for doing this is so that a combined BLE and LoRa stack do not have conflicting os cputime frequencies.
mkiiskila
approved these changes
Aug 31, 2017
Contributor
mkiiskila
left a comment
mkiiskila
left a comment
There was a problem hiding this comment.
I wish the code did not export symbols like 'Send()'. Changes look ok.
Author
|
I know what you mean re: some of the exported symbols. I can change them prior to release if folks think it is important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.