nimble/ll: Fixes for Data Length Extension#614
Merged
andrzej-kaczmarek merged 6 commits intoapache:masterfrom Feb 5, 2018
Merged
nimble/ll: Fixes for Data Length Extension#614andrzej-kaczmarek merged 6 commits intoapache:masterfrom
andrzej-kaczmarek merged 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
this needs some more changes |
sjanc
previously approved these changes
Oct 13, 2017
Contributor
|
test this please Using our bot for tests. Not asking the PR author for testing. |
Contributor
|
@andrzej-kaczmarek Can we have it updated before UPF? |
andrzej-kaczmarek
force-pushed
the
nimble-ll-dle-fix
branch
2 times, most recently
from
a485f63 to
e2a7533
Compare
Max TX time (regardless of PHY) is 17040us since this is maximum value allowed by HCI commands and we should accept it. This does not mean we will use whatever hosts requests since these are just suggestions and we calculate actual supported and effective TX time taking into account connection settings and other limitations from spec.
We should reply LL_UNKNOWN_RSP if CtrlData received from peer are invalid [1]. This means, we only have to check if TX/RX values for time and octets are not less than 328 and 27 respectively [2]. Any other value received shall be accepted - we will calculate effective values for both octets and time to be within limits anyway. In addidion, even if LL_LENGTH_RSP does not have valid data we should end procedure since there is no exception for this in spec [3]. We do not apply invalid parameters, but also won't hit procedure timeout. Core specification v5.0, Vol 6, Part B [1] section 2.4.2 [2] section 2.4.2.21 [3] section 5.1.10
We did not properly adjust payload length for 2nd and subsequent packet fragments so in case effectiveMaxTxTime is less than time required to send payload of effectiveMaxTxOctets, we send too many data in all packets except 1st one.
In Core specification 5.0 upper limit for TxTime is 17040 (0x4290).
andrzej-kaczmarek
force-pushed
the
nimble-ll-dle-fix
branch
from
e2a7533 to
466d02b
Compare
andrzej-kaczmarek
changed the title
rymanluk
approved these changes
Feb 5, 2018
Contributor
rymanluk
left a comment
rymanluk
left a comment
There was a problem hiding this comment.
Looks good, also tested on UPF59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.