nimble/ll: Fix handling HCI ACL data#1983
Merged
andrzej-kaczmarek merged 2 commits intoapache:masterfrom Feb 25, 2025
Merged
Conversation
For whatever reason HCI ACL packets with empty payload are allowed, but at the same time we are not allowed to send and empty fragment with LLID=0b00 over the air. We need to wait for the 1st non-empty payload and "recombine" it with the empty payload(s) to form a proper payload with LLID=0b00. We don't really need to recombine payloads, instead we can just count and then discard initial empty payloads and the update non-empty payload accordingly. See Core 6.0, Vol 6, Part B, 2.4.1.
We can (and shall) keep sending nocp event with ncp=0 periodically but *only* if we have HCI data packets enqueued. Currently we check if txq is empty but that doesn't take into account that the only queued PDUs may be LL Control. This adds extra counter to track number of data PDUs queued in conn.
sjanc
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes handling of HCI ACL data in two scenarios: