Use syscfg settings for sysinit stage numbers#232
Merged
ccollins476ad merged 2 commits intoapache:masterfrom Nov 21, 2018
Merged
Use syscfg settings for sysinit stage numbers#232ccollins476ad merged 2 commits intoapache:masterfrom
ccollins476ad merged 2 commits intoapache:masterfrom
Conversation
ccollins476ad
changed the title
ccollins476ad
changed the title
rymanluk
reviewed
Nov 19, 2018
nimble/host/mesh/pkg.yml
Outdated
| bt_mesh_register_gatt: 500 | ||
| ble_mesh_shell_init: 1000 | ||
| bt_mesh_register_gatt: 'MYNEWT_VAL(BLE_MESH_SYSINIT_STAGE)' | ||
| ble_mesh_shell_init: 'MYNEWT_VAL(BLE_MESH_SYSINIT_STAGE_2)' |
Contributor
There was a problem hiding this comment.
Can we use BLE_MESH_SHELL_SYSINIT_STAGE instead of BLE_MESH_SYSINIT_STAGE_2?
Contributor
Author
There was a problem hiding this comment.
Thanks, @rymanluk. I agree that BLE_MESH_SYSINIT_STAGE_2 is a poor name.
I renamed it to BLE_MESH_SYSINIT_STAGE_SHELL rather than your suggestion of BLE_MESH_SHELL_SYSINIT_STAGE. I don't have a preference either way, but I already chose this arbitrary convention for other packages with multiple sysinit stages.
I pushed this commit separately with the intent to fixup before merging.
rymanluk
requested changes
Nov 19, 2018
Contributor
rymanluk
left a comment
rymanluk
left a comment
There was a problem hiding this comment.
Change looks great, just one minor comment on one MYNEWT_VAL name.
ccollins476ad
force-pushed
the
syscfg-stage
branch
from
016a012 to
bf71a67
Compare
This allows the app or target to rearrange package initialization order via syscfg overrides. Note: This requires an updated version of newt (apache/mynewt-newt#230). Older versions of newt fail to parse the updated `pkg.yml` files.
ccollins476ad
force-pushed
the
syscfg-stage
branch
from
bf71a67 to
f6b17f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the app or target to rearrange package initialization order via syscfg overrides.
**Note: This requires an updated version of newt
(apache/mynewt-newt#230). Older versions of newt fail to parse the updated
pkg.ymlfiles.I wanted to make this change backwards compatible via an injected newt syscfg setting, e.g.,
Unfortunately, this is not possible, as the old newt does not allow conditionals to be applied to
pkg.init. So, as soon as this PR is merged, everything will break for users using older versions of newt.I think it is still worth it to get this change in. Before we merge, we can send a note to the dev list and the slack channel. When 1.6.0 is released, we can make sure to add the appropriate newt version restriction.