nimble: Add initial support for Core Spec 5.1#490
Merged
sjanc merged 1 commit intoapache:masterfrom Oct 15, 2019
Merged
Conversation
sjanc
requested review from
andrzej-kaczmarek and
rymanluk
and removed request for
rymanluk
bassammohy
suggested changes
Jun 17, 2019
nimble/include/nimble/hci_common.h
Outdated
| #define BLE_HCI_LE_PERIODIC_ADV_SET_INFO_TRANSFER_LEN (5) | ||
|
|
||
| /* --- LE Set Periodic Advertising Sync Transfer Parameters (OCF 0x005C) */ | ||
| #define BLE_HCI_LE_PERIODIC_ADV_SYNC_TRANSFER_PARAMS_LEN (9) |
Contributor
There was a problem hiding this comment.
length is 8 not 9
Connection_Handle, 2
Mode, 1
Skip, 2
Sync_Timeout, 2
CTE_Type 1
Contributor
Author
There was a problem hiding this comment.
good catch, thanks
although I've started working on reworking code we have for parsing hci commands/events which will make those defines obsolete, I'll rebase this patch on top of that work when it is done.
andrzej-kaczmarek
approved these changes
Sep 25, 2019
This only adds required defines for new HCI commands and events. Option for selecting supported core version is also added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only adds required defines for new HCI commands and events.
Option for selecting supported core version is also added.